Make Interceptor more thread-safe
#392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several methods in `Interceptor` currently read and modify a private dictionary without any synchronization or locking, which means that if someone tries to perform several setups concurrently on the same mock, they might run into a some multithreading-related exception every now and then.
stakx
force-pushed
the
interceptor-thread-safety
branch
from
4f3382f
to
970981d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several methods in
Interceptorcurrently read and modify a private dictionary without any synchronization or locking, which means that if someone tries to perform several setups concurrently on the same mock, they might run into a some multithreading-related exception every now and then.Performing concurrent setups on the same mock is probably not a very frequent use case, but it can't hurt to make Moq more thread-safe.
This should take care of #326.