Make abstract events defined in classes work even when CallBase is true
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test shows how it is currently impossible to subscribe an event handler (and then raise the event) if the event is abstract, defined in an abstract class, and `CallBase` is set to true.
`InvokeBase()` should not just be suppressed for events defined in interfaces, but also for abstract events. The latter category in fact includes the former, so that's all we really need to check for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moq does not currently mock an abstract event defined in a class correctly when a mock's
CallBaseis set to true. It will try to invoke the base event accessors (which are definedabstractin this case), which leads to DynamicProxy triggering aNotImplementedException.This PR corrects that bug by suppressing the call to
InvokeBasefor event attach / detach accessors when the base accessor methods are abstract. (Up until now, such a check was in place only for events defined in interfaces.)This fixes #296.