Allow Mock<T>.Raise to raise events on child mocks
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These three tests show that `Mock.Raise` does not correctly raise
events of "child mocks" in an expression such as:
mock.Raise(_ => _.Foo.Bar.Event += null, ...)
^^^^^
stakx
commented
Jun 28, 2017
| @@ -503,7 +503,7 @@ public void Raise(Action<T> eventExpression, EventArgs args) | |||
|
|
|||
| try | |||
| { | |||
| this.DoRaise(ev, args); | |||
| ev.Target.DoRaise(ev.MemberInfo, args); | |||
There was a problem hiding this comment.
Replacing this with ev.Target is what really fixes this issue.
stakx
commented
Jun 28, 2017
| @@ -352,7 +352,7 @@ public void DoesNotRaiseEventOnSubObject() | |||
|
|
|||
| mock.Raise(p => p.Adder.Added += null, EventArgs.Empty); | |||
|
|
|||
| Assert.False(raised); | |||
| Assert.True(raised); | |||
There was a problem hiding this comment.
Note that this is in effect a functional change. The changes of this change breaking any client code are probably quite small (see #166 (comment)).
At the same time, replacing this unit test with its exact opposite also has the advantage of fixing an inconsistency, since the quickstart guide already documents the ability to raise events on sub-objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #166.