Improve method match accuracy in ExtractProxyCall
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're setting up methods in a type hierarchy (e.g. `Base.Method` and `Derived.Method`), the setup order currently matters, even though two different methods are set up. This commits is a first step in making Moq associate the "right" setup with a proxy method invocation. This will make sure that if there are several setups that potentially match an invocation, it will attempt to pick the one for the exact same method. This is only a start, but probably still not good enough in all situations (for example, for overridden methods, the distance of the inheritance relationship is not taken into account).
stakx
commented
Jul 12, 2017
| } | ||
| } | ||
| localctx.Call = lastMatchingSetupForSameMethod ?? lastMatchingSetup; | ||
| } |
There was a problem hiding this comment.
At first glance, this looks much more involved than a simple LastOrDefault, but it has the advantage of only performing a single enumeration over ctx.OrderedCalls while looking for two different items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're setting up methods in a type hierarchy (e.g.
Base.MethodandDerived.Method), the setup order currently matters, even though two different methods are set up.This commits is a first step in making Moq associate the "right" setup with a proxy method invocation. This will make sure that if there are several setups that potentially match an invocation, it will attempt to pick the one for the exact same method.
This is only a start, but probably still not good enough in all situations (for example, for overridden methods, the distance of the inheritance relationship is not taken into account).
This should fix #131.
/cc @dcastro, @pjquirk