Fix misreported setup Times in Verify messages
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `mock.Verify` fails, it lists the mock's setups in the exception message. However, it reports actual invocation counts as the number of expected calls set up, which is incorrect. Moq currently allows only one kind of expected call count setup (both of which have been obsoleted): `.AtMostOnce()` and `.AtMost(n)`. The current logic for formatting a setup is moved to `MethodCall` where it rightly belongs and where the expected call count limit is accessible.
stakx
force-pushed
the
verify-misreports-setup-times
branch
from
9cc1f78
to
18416fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #211.
When
mock.Verifyfails, it lists the mock's setups in the exception message. However, it reports actual invocation counts as the number of expected calls set up, which is misleading at best and incorrect at worst.Moq currently allows only two kinds of expected call count setups (both of which have been obsoleted):
.AtMostOnce()and.AtMost(n). The current logic for formatting a setup is moved toMethodCall(the class representing a setup) where it rightly belongs, and where the expected call count limit is accessible.This change will also make it easier to introduce the ability to specify any
Timeson a setup, if that's what gets decided in #373.