Added covariant IMock<out T> interface to Mock<T> #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2013 11:13
Moq.csproj had them conditionally resoved but that part was commented out from Moq.Tests.csproj. As a result, you could compile but not run tests in .NET 4.0. Since 4.0 is critical for the feature I'm implementing, I had to fix this.
I wanted to be able to write test utilities for setting up more complicated
object interactions. I wanted to make a method with this signature:
void Method<T>(Mock<IService<T>> serviceMock);
that could recieve an object of type `Mock<IFooService>` as a parameter (where
`IFooService` extends `IService<Foo>`). Since only interfaces and delegates
can be covariant, the raw `Mock<T>` won't work. This pull request lets me use
this method:
void Method<T>(IMock<IService<T>> serviceMock);
The `IMock<T>` interface exposes only the members where we can still make
`IMock<T>` covariant (i.e. nothing that has `T` in the parameter list).
kzu
added a commit
that referenced
this pull request
May 27, 2013
Added covariant IMock<out T> interface to Mock<T>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to write test utilities for setting up more complicated
object interactions. I wanted to make a method with this signature:
that could recieve an object of type
Mock<IFooService>as a parameter (whereIFooServiceextendsIService<Foo>). Since only interfaces and delegatescan be covariant, the raw
Mock<T>won't work. This pull request lets me usethis method:
The
IMock<T>interface exposes only the members where we can still makeIMock<T>covariant (i.e. nothing that hasTin the parameter list).