Switch back from portable PDBs to classic PDBs #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to Visual Studio 2017 Update 3, the Roslyn compilers only supported SourceLink for the new portable PDB format. With Update 3, SourceLink is also supported with the classic Windows PDB format. This commit reverts back from portable PDBs to classic PDBs because some existing .NET tooling (among them TFS, apparently) simply cannot yet deal with portable PDBs correctly, causing some people's build processes to fail.
1. It appears that `dotnet sourcelink test` cannot yet read classic
PDBs with SourceLink information correctly.
2. Verification only lets builds succeed if all code changes have
been pushed to GitHub. This stops people from being able to build
Moq with only local changes (at least when the build script is
used).
stakx
force-pushed
the
sourcelink-nonportable-pdbs
branch
from
9bfd3e4
to
fd3918f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Visual Studio 2017 Update 3, the Roslyn compilers only supported SourceLink for the new portable PDB format. With Update 3, SourceLink is also supported with the classic Windows PDB format. This PR reverts back from portable PDBs to classic PDBs because some existing .NET tooling (among them TFS, apparently) simply cannot yet deal with portable PDBs correctly, causing some people's build processes to fail.
This is intended to fix #428.