Improve Setup recognition logic for sealed methods
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Setup` is expected to throw an exception if an attempt is made to set up a property that cannot be mocked. The 4 tests added in this commit demonstrate that Moq fails to recognize virtual, but sealed properties as uninterceptable.
It turns out that the C# compiler puts the wrong `PropertyInfo` in an `Expression` for properties in derived classes. Apparently, it always puts in the `PropertyInfo` corresponding to the property's base dec- laration instead of the `PropertyInfo` of the accessed type. This commit adds a clause to the `expression.ToPropertyInfo` extension method to counteract this peculiar compiler behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #496.
Given the two types
FooBaseandFooin that issue and the following expression tree:If one inspects the
PropertyInfothat the compiler puts intoexpressionforfoo.Property, it'll be thePropertyInforepresentingFooBase.Propertyinstead ofFoo.Property. (See also the this Stack Overflow question, "ReflectedType from MemberExpression".)This PR adds code to Moq's
expression.ToPropertyInfo()extension method to counteract this peculiar C# compiler behaviour.