Let SetupAllProperties skip inaccessible methods
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Oct 22, 2017
| @@ -727,11 +727,12 @@ private static void SetupAllProperties(Mock mock, Stack<Type> mockedTypesStack) | |||
| // interface as a getter-and-setter property. | |||
| .Where(p => | |||
| p.CanRead && p.CanOverrideGet() && | |||
| p.GetIndexParameters().Length == 0 && | |||
There was a problem hiding this comment.
This condition gets moved from 2nd to 3rd position because it's more expensive.
stakx
commented
Oct 22, 2017
| // (a) those that are read-only; and | ||
| // (b) those that are writable and whose setter can be overridden. | ||
| p.GetIndexParameters().Length == 0 && | ||
| ProxyFactory.IsMethodVisible(p.GetGetMethod(), out _)) |
There was a problem hiding this comment.
This is the additional missing condition that fixes the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #498.