Remove leaked MockVerificationException and catch-throw-recatch cycle during verification
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Nov 2, 2017
Source/Obsolete/MockFactory.cs
Outdated
|
|
||
| foreach (var mock in mocks) | ||
| { | ||
| try | ||
| { | ||
| verifyAction(mock); | ||
| } | ||
| catch (MockVerificationException mve) | ||
| catch (MockException ex) when (ex.Error is UnmatchedSetups failure) |
There was a problem hiding this comment.
Unfortunately the throw-catch pattern cannot be replaced with a full try pattern due to this method's signature and the fact that it's protected. It would have to be marked as [Obsolete].
stakx
force-pushed
the
mockverificationexception
branch
2 times, most recently
from
917a14c
to
addc2d8
Compare
Instead of only being able to hold a instance of `UnmatchedSetups`, make `MockException` more general so it can hold different kinds of error objects. Towards that end, introduce a new `IError` interface.
stakx
force-pushed
the
mockverificationexception
branch
from
addc2d8
to
3915bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #507.