Turn collection of source file information per setup into an opt-in feature #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
hotfix-stacktrace-info
branch
2 times, most recently
from
b4dbc99
to
80c7961
Compare
Up until now, Moq has been collecting source file information for each setups created. This comes at a slight performance penalty. At this moment, there is a regression in the .NET Framework which means this penalty becomes gigantic. This commit turns source file information collection into an opt-in feature. Towards that end, a `Switches` property is added to `Mock` and `MockRepository` which allows users to opt in or out of certain features. Source file info collection is controlled via the switch `Switches.CollectDiagnosticFileInfoForSetups`.
stakx
force-pushed
the
hotfix-stacktrace-info
branch
from
80c7961
to
4fbd597
Compare
|
Merging this directly, not via PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, Moq has been collecting source file information for each setup created. This came at a slight performance penalty. There is currently a regression in the .NET Framework which means this penalty becomes gigantic (more expensive than proxy creation!).
This commit turns source file information collection into an opt-in feature. Towards that end, a
Switchesproperty is added toMockandMockRepositorywhich allows users to opt in or out of certain features. Source file info collection is controlled via the switchSwitches.CollectDiagnosticFileInfoForSetups.