Rewrite EmptyDefaultValueProvider to use dictionary lookup for special type handling
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Nov 19, 2017
|
|
||
| var setResultMethod = tcs.GetType().GetMethod("SetResult"); | ||
| var taskProperty = tcs.GetType().GetProperty("Task"); | ||
| private static object CreateTaskOf(Type type) |
There was a problem hiding this comment.
Interestingly enough, while creating a completed task via Task.FromResult<T> is about 16x as fast as via TaskCompletionSource<T>, the same is not true if done via reflection: Task.FromResult<T> then becomes a little slower even though less reflection calls are involved. So we don't change over to a Task.FromResult-based solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lot more efficient (I observed speed-ups of simple mock method invocations by 67%) and makes it possible to easily add handling of additional types that are currently ignored (such as
List<T>,IReadOnlyList<T>, etc.).