Optimize a few aspects of the interception process #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `argumentMatchers` is constructed, `out` parameters are filtered out. This makes things harder (and slower) than necessary. Instead of removing `out` parameters, match them with the dummy `AnyMatcher`.
Make both `Method` and `Arguments` non-virtual properties of the base class. This makes querying those properties faster because delegation to DynamicProxy is avoided. Letting the base class handle `Arguments` means that deriving classes must be explicitly notified about an invocation's end, so that they can write back modified arguments to by-ref parameters. That is what the three new `Return` methods are for. Having Moq explicitly end an invocation makes it possible for Dynamic- Proxy's `Invocation` subclass to "detach" itself from the underlying `IInvocation` when is no longer needed, so it can be GC'ed earlier.
`SetupCollection.FindMatchFor(Invocation)`: Add a fast path for the
case when there are no setups at all.
`InvokeBase`: Rewrite the convoluted condition that checks whether the
base method can / should be called. Problems with the current checks:
1. It's almost impossible to make sense of.
2. The least expensive checks (such as checking `mock.CallBase` or
`invocation.Method.IsAbstract`) happen last.
3. Many checks are unnecessary because they never evaluate to true.
For example, `object` methods have already been dealt with in
`HandleWellKnownMethods`; event attach / detach methods have been
dealt with in `RecordInvocation`.
These two invocation aspect handlers essentially have the same pur- pose: ending an invocation and producing a return value (if required).
Strict mocks require that setups explicitly provide a return value. This check is unnecessary for void method setups. Let's therefore move it into `MethodCallReturn`.
stakx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.