Issue #572 Setup cannot invoke callback with different number of parameters in Moq 4.8.1 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
suggested changes
Jan 17, 2018
Source/MethodCallReturn.cs
Outdated
| @@ -42,7 +42,7 @@ | |||
| using System.Globalization; | |||
| using System.Linq.Expressions; | |||
| using System.Reflection; | |||
|
|
|||
| using System.Runtime.CompilerServices; | |||
There was a problem hiding this comment.
Please move this line a little further up so that using System.* are properly sorted. Also, restore the blank line between using System.* and using Moq.*.
There was a problem hiding this comment.
About sorting - Runtime is definitely after Reflection, isn't it?
Blank line is my fault - suspect VS dit that :)
There was a problem hiding this comment.
Uhhh... yes indeed. You're right, of course. :-)
|
Merged. Thanks again for taking the time to submit a fix! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more parameters to test method as 0 and 1 parameters are special cases for parameterless and extension methods.
Add tests for extension methods with different number of parameters.