Clean up MockException (and deprecate IError along the way)
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit showed that even for aggregate mock verification, we can simply concatenate error messages. Since `MockException` (like any other exception type) already carries a message, as well as a `reason` enum value, `MockException` provides all the payload we need and we can drop the `IError` abstraction. Instead of having many different `IError` types, we introduce simple static factory methods in `MockException` that correspond to the `MockExceptionReason` enum values. That way, we can pull the error message building into a single place and clean up the throw sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MockExceptioncurrently feels quite messy because it has many similar constructors that all do something slightly different. It's dificult to understand what kind of exception is built up at the throw sites. Also, someMockExceptions have anIErrorpayload, while others don't. Either we should goIErrorall the way, or remove it.This PR opts for removing the
IErrorabstraction by introducing static factory methods onMockException. This is done by making the additional payload capabilities ofIErrorobsolete. (We only need this for mock repository batch verification, but it turns out we can avoid that need by simply making the batch error messages more informative!)