Replace parameter list comparison extension methods #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check being removed here was introduced by devlooped#335, which fixed a regression by reproducing type matching logic from the .NET reference source for `Type.GetMethod(string, BindingFlags, Binder, Type[], ..)`. This check is likely not needed, and we have no test that demonstrates why it might be needed. Removing this special check however will allow us to merge the method it appears in with other similar methods.
stakx
commented
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently several different ways in the Moq code base for comparing ordered lists of (parameter) types:
Enumerable.SequenceEqualEnumerable.SequenceEqual+AssignmentCompatibilityTypeComparerExtensions.HasSameParameterTypesAsExtensions.HasCompatibleParameterTypesExtensions.HasCompatibleParameterListThis refactoring replaces all of the above with three new composable building blocks:
ParameterTypes— wrapper forParameterInfo[]so it can be treated likeType[]Extensions.GetParameterTypes— gets aMethodInfo's parameter types as aParameterTypesExtensions.CompareTo— compares any pair ofType[]orParameterTypesusing either of two comparison modes: equality, or assignment-from-compatibility.Care has been taken to keep them fast, and free of any heap allocations.