Make MockFactory.VerifyMocks
do what it says it does
#691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML documentation comment for
MockFactory.VerifyMocks(Action<Mock> verifyAction)
states the purpose of that method as follows:However this is not what the method has been doing up until now. It hasn't accumulated any verification errors, but only those caused by unmatched setups (i.e. those exceptions thrown by
Verify
andVerifyAll
).This PR makes the
VerifyMocks
method adhere to its own stated purpose by cleaning upMockException
aggregation a little. This also allows us to reuseVerifyMocks
inMockFactory.VerifyNoOtherCalls
.