Merge duplicate FluentMockVisitor classes
#698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces two small, benign changes: * `Mock`'s visitor now has an unused field `isFirst`. * LINQ's visitor now allows compiler-generated field accesses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Moq code base contains two very similar classes named
FluentMockVisitor:Mockclass,MockSetupsBuilderclass.Both of these have a very similar function, namely auto-mocking all method and property accesses in a multi-dot setup expression, and optionally adding the whole expression as a setup to the rightmost mock.
This refactoring merges both of these implementations into a single class.