Merge MethodCallReturn into MethodCall
#717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it possible to remove quite a bit of duplicate code in the `Mock` class' internal static methods. Merging `MethodCallReturn` and `MethodCall` could easily make the re- sulting class heavier for void methods. Because of this, we merge some fields as well. The net result should be a slightly higher memory footprint for void methods, and a smaller memory footprint for non- void methods.
The setup functions `.AtMostOnce()` and `.AtMost(n)` are deprecated and probably used only sparingly in practice. This commit offloads all state associated with these methods into a separate object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to remove quite a bit of duplicate code in the
Mockclass' internal static methods later on.Merging
MethodCallReturnandMethodCallcould easily increase the resulting class' memory footprint when it only represents void methods. Because of this, we merge some fields as well. The net result should be a minimally higher memory footprint for void methods, and a smaller memory footprint for non-void methods.