Check IsSpecialName for properties & indexers
#718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
properties-isspecialname
branch
2 times, most recently
from
052693c
to
29cfd9a
Compare
stakx
changed the title
IsSpecialName check for propertiesIsSpecialName for properties & indexers
This is a follow-up to devlooped#712 and devlooped#713, where we added tests documenting F# and COM events not being marked with the IL `specialname` flag. But as it turns out, F# and COM *properties and indexer* accessor methods are marked as `specialname`, which we document here using unit tests. Finally, we bring back checks for `method.IsSpecialName` for property and indexer accessor method recognition.
stakx
force-pushed
the
properties-isspecialname
branch
from
29cfd9a
to
1b45b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #712 and #713, where we added tests documenting F# and COM events not being marked with the IL
specialnameflag.But as it turns out, F# and COM properties and indexers are marked as
specialname, which we document here using unit tests. Finally, we bring back checks formethod.IsSpecialNamefor property & indexer accessor method recognition.