Enable FluentMockContext to record >1 matcher per invocation
#722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moq currently cannot correctly deal with setter setups using more one matcher, e.g. when setting up an indexer's setter. This is because the `FluentMockContext` only associates at most one matcher with observed invocations. This commit changes how `FluentMockContext` records its observations and how it lets the outside world access them. When asked for the last observed mock invocation, `FluentMockContext` now returns *all* matchers observed immediately before the final invocation.
Way too many things in Moq's code base are referred to as "fluent". Let's try to give this component a somewhat more descriptive name.
stakx
commented
Nov 11, 2018
stakx
force-pushed
the
fluentmockcontext
branch
from
fa4af52
to
c637337
Compare
* Add static `Activate` method that client code uses instead of the ctor; so that there is better symmetry with `IsActive`. * Abbreviate method names to `LastIsInvocation`, `LastIsMatch`, also to mirror `OnInvocation`, `OnMatch` more closely. * Introduce `expression.IsMatch` helper method that abstracts away a `AmbientObserver` usage pattern repeated 3x across the code base.
stakx
force-pushed
the
fluentmockcontext
branch
from
c637337
to
00b630a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moq currently cannot correctly deal with setter setups using more one matcher, e.g. when setting up an indexer's setter. This is because the
FluentMockContextonly associates at most one matcher with observed invocations.This PR changes how
FluentMockContextrecords its observations and how it lets the outside world access them. When asked for the last observed mock invocation,FluentMockContextnow returns allmatchers observed immediately before the final invocation.
The class is also renamed to
AmbientObserver(way too many things in Moq's code base are called "fluent") and documented somewhat better using XML documentation comments and tests.