Make System.Object members interceptable by *any* interceptor
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing tests added in this commit demonstrate that `ProxyFactory` doesn't currently guarantee interceptability of `Object` methods under all circumstances. More precisely, `Object` methods are currently not interceptable if: * the proxied type is an interface type, and * the interceptor used is not an instance of the `Mock` class.
These methods should be interceptable by all interceptors, regardless of their type. (So far, this only worked for `Mock` interceptors.)
stakx
commented
Mar 2, 2019
| // All generated proxies need to implement `IProxy`: | ||
| var additionalInterfaces = new Type[1 + interfaces.Length]; | ||
| additionalInterfaces[0] = typeof(IProxy); | ||
| Array.Copy(interfaces, 0, additionalInterfaces, 1, interfaces.Length); |
There was a problem hiding this comment.
It's a pity that this kind of thing happens twice now; once to add IMocked<T> for Mock, and once here, to add IProxy for IInterceptor. It would be nice to eventually optimize this a little.
This was referenced Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Objectmethods are currently not interceptable if the proxied type is an interface type, and the interceptor used is not an instance of theMockclass. These methods should be interceptable by all interceptors, regardless of their type.As it happens, this requires the introduction of an
IProxyinterface which is toIInterceptorwhatIMockedis toMock. It works in exactly the same fashion, too.This PR might seem a bit pointless, since the only implementation of
IInterceptoris theMockclass, so at the surfaceIMockedshould suffice.However, this lays the groundwork for my next PR, which will introduce some new machinery for converting
Action<T>delegates back toExpression<Action<T>>(which is important to fix some long-standing bugs with e.g.SetupSet). That PR will require a new interceptor type... so we'll needIProxyanyway.