Replace LambdaExpressionPart with InvocationShape
#776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as it has become less light-weight (due to two additional fields).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step-by-step refactoring with the sole (AFAIK) side-effect of argument matchers being created from expressions a little earlier than was the case so far... which is actually good from a validation perspective.
The rationale behind this refactoring is that we want to further improve handling of recursive / fluent expressions. There are still cases where arguments in intermediate parts of such expressions are still just treated like
It.IsAny<TArg>(). If we want to improve this, we'll need access to anySetup'sArgumentsfor comparison before creating a newInnerMockSetup.