InvocationShape should be equality-comparable
#777
Conversation
| return false; | ||
| } | ||
|
|
||
| if (this.Arguments.Count != other.Arguments.Count) |
There was a problem hiding this comment.
This could probably be just an assertion. The argument count should always be equal if the methods are already the same.
|
|
||
| if (this.partiallyEvaluatedArguments == null) | ||
| { | ||
| this.partiallyEvaluatedArguments = PartiallyEvaluateArguments(this.Arguments); |
There was a problem hiding this comment.
It might be good to someday think about whether this needs additional precautions for thread-safety. For now I'll pretend to be naïve and think that this operation would yield the same result even when called several times by several threads, so it's fine to just let the last evaluation win.
|
|
||
| if (other.partiallyEvaluatedArguments == null) | ||
| { | ||
| other.partiallyEvaluatedArguments = PartiallyEvaluateArguments(other.Arguments); |
| @@ -21,6 +21,8 @@ protected Setup(InvocationShape expectation) | |||
|
|
|||
| public virtual Condition Condition => null; | |||
|
|
|||
| public InvocationShape Expectation => this.expectation; | |||
|
|
|||
| public LambdaExpression Expression => this.expectation.Expression; | |||
There was a problem hiding this comment.
Should check whether Expression, Method still need to be exposed at all now that they'd be accessible through Expectation. It might be convenient to keep them around.
| @@ -86,7 +86,7 @@ public Setup[] ToArrayLive(Func<Setup, bool> predicate) | |||
| // The following verification logic will remember each processed setup so that duplicate setups | |||
| // (that is, setups overridden by later setups with an equivalent expression) can be detected. | |||
| // To speed up duplicate detection, they are partitioned according to the method they target. | |||
There was a problem hiding this comment.
That partitioning might no longer be as crucial as before, since the first equality check Invocation.Equals performs is for the MethodInfos to be equal.
Another refactoring that makes
InvocationShapethat will be needed shortly. It also permits a clearer phrasing inSetupCollectionwhen a setup overrides another.