Remove Pex interop code #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moq's interop bits to better support Pex haven't been maintained in a long time, and doing so today is difficult for an open-source project, as Pex's successor (IntelliTest) is not part of free VS edition. There's little reason to believe that the Pex guards (`PexProtector`) are still in the right place today. It would seem likely that instead of guarding random `Setup` methods, delegate compilation and dynamic code generation would have to be guarded... but we cannot easily test this assumption without VS Ultimate/Enterprise. Therefore, let's drop whatever Pex support we may still have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moq's interop bits to better support Pex haven't been maintained in a long time, and doing so today is difficult for an open-source project, as Pex's successor (IntelliTest) is not part of free VS edition.
There's little reason to believe that the Pex guards (
PexProtector) are still in the right place today. It would seem likely that instead of guarding randomSetupmethods, delegate compilation and dynamic code generation would have to be guarded... but we cannot easily test this assumption without VS Ultimate/Enterprise.Therefore, let's drop whatever Pex support we may still have.