Keep InvocationShape argument matchers & expressions in sync
#793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit's test fails because during invocation-to-setup matching, an argument expression gets re-evaluated that wouldn't have to be re-evaluated; it has previously been associated with a constant matcher. Looking more closely at `MatcherFactory` it becomes obvious that arg- ument matchers are in some cases derived from partially evaluated ex- pressions; but those never make it back into the setup expression and therefore end up "disagreeing" with their associated matchers. Note that this bugfix adds yet another layer of complexity to matcher types by letting `MatcherFactory` return `Pair<,>` instances. It would perhaps be better to simply let `IMatcher`s carry the `Expression` from which they were derived, however that ends up being a more com- plicated refactoring mostly due to `Match` and `ParamArrayMatcher`. Let's do that another time.
stakx
commented
Apr 1, 2019
`MatcherFactory.CreateMatcher` has been refactored in a earlier commit to return expressions that are in sync with the created matchers; ex- cept for `ParamArrayMatcher`.
stakx
changed the title
InvocationShape's argument matchers & expressions shouldn't go out of syncInvocationShape argument matchers & expressions in sync
stakx
commented
Apr 1, 2019
stakx
commented
Apr 2, 2019
| /// example, while <see langword="int"/> is assignable-to <see langword="object"/>, you | ||
| /// will need a conversion in a LINQ expression tree to model the value-type boxing operation. | ||
| /// </remarks> | ||
| internal static Expression ConvertIfNeeded(this Expression expression, Type type) |
There was a problem hiding this comment.
-
Check whether this method can be reused in
ActionObserver, which currently has its own (but slightly different) logic for doing the same thing. -
Also, add a set of tests that test our assumptions (stated here informally inside
<remarks>) about whenConvertnodes are necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711. See explanation in #711 (comment) as well as in commit messages for details.