Consolidate public extension method classes #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as the other `ObsoleteMockExtensions` class already holds `Mock<T>` extension methods, and those in `MockLegacyExtensions` can join them.
...and move them to `ObsoleteMockExtensions` at the same time. The `[EditorBrowsable]` bug mentioned in the original comment is no longer observable in a current version of Visual Studio (2017 / 15.9.10).
No need to have two separate classes. A distinction is already made at the file level by separating obsolete stuff out into the `Obsolete` directory.
Those are identical to the instance methods they forward to, so there is no point in keeping them around.
...to be in line with the usual convention of naming extension method classes after the type that they extend. Note that the class MUST remain in the `Moq.Protected` namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public extension methods are spread out over way too many static classes, this PR rearranges them a little.