Revert binary backward-incompatible changes #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
changed the title
* bf19ad6: Make `Mock.Object` non-virtual * ccf9a02: Remove yet another superfluous extension method class * 49a2ccf: Rename extension method for `mock.Protected()` * 41ef023: Put async extension methods in `AsyncExtensions` * 8aacd8b: Remove superfluous extension methods * f605bfe: Fix name of class gen'd by `ReturnsExtensions.tt` * 6fadc8f: Merge `ObsoleteMockExtensions` into `MockExtensions` * 0cbdd87: Convert `Expect*` methods into extension methods * 0669d43: Remove redundant class `MockLegacyExtensions` * 85e0e7d: `MockFactory` <--> `MockRepository` Those would be completely fine for people relying on Moq directly, as they could simply recompile their code. However, for anyone using Moq through a 3rd-party library that was compiled against an earlier ver- sion, they break user code due to binary incompatibility. Forcing all 3rd-party libs to recompile and republish without protecting them with a semver major version increase is perhaps asking a bit much. :)
stakx
force-pushed
the
binary-backward-compatibility
branch
from
730059b
to
c2c90ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking people's code just for the sake of a better organized code base is probably not worth it. We should at least raise the major version number (which we cannot do at this time). So revert.