Optimize SetupCollection (esp. ToArrayLive) for better performance
#819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly partitioning setups by `MethodInfo` is not necessary since `InvocationShape.GetHashCode` in essence already does this, so we can just use a `HashSet<..>` instead of a `Dictionary<MethodInfo, ..>`.
...using simple bit mask checks. This helps avoid much more expensive operations such as comparing expression trees. This optimization only applies to the first 32 setups as that will be sufficient in many real world scenarios and means we don't need a (more complicated) variable- sized bit vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetupCollection.ToArrayLiveis a fairly expensive operation and gets called more often (esp. during verification) now that inner mocks are represented as regular setups. This applies some optimizations that can easily double the speed of that operation (or more!), esp. when any overridden setups are present.