Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle write-only properties in SetupAllProperties for strict mocks (fix #835) #836

Merged

Conversation

ishimko
Copy link
Contributor

@ishimko ishimko commented Jun 1, 2019

Fix #835.

Was not sure, if such a minor change should be included in a changelog, but included just in case.

@ishimko ishimko force-pushed the setupallproperties-write-only-properties branch 2 times, most recently from d73b768 to 83f5749 Compare June 1, 2019 11:33
@ishimko ishimko marked this pull request as ready for review June 1, 2019 11:34
Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Having a changelog entry seems appropriate since it's a change in behavior that someone could conceivably run into.

Just one very minor detail, if you care to fix it that's cool, otherwise I'll go ahead and merge this soon.

tests/Moq.Tests/StubExtensionsFixture.cs Outdated Show resolved Hide resolved
@stakx stakx added this to the 4.11.1 milestone Jun 1, 2019
@ishimko ishimko force-pushed the setupallproperties-write-only-properties branch from 83f5749 to 16d19d2 Compare June 1, 2019 16:04
@stakx stakx merged commit d516c95 into devlooped:master Jun 1, 2019
@stakx stakx modified the milestones: 4.11.1, 4.12.0 Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetupAllProperties does not setup write-only properties
2 participants