Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifyNoOtherCalls: Prevent stack overflow by remembering already verified mocks #848

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Jun 6, 2019

Fixes #846. Thanks again for reporting this defect!

/cc @bash, @jnferner, @Mafii

@stakx stakx added this to the 4.12.0 milestone Jun 6, 2019
@stakx stakx merged commit 07139a3 into devlooped:master Jun 6, 2019
@stakx stakx deleted the verifynoothercalls branch June 6, 2019 18:05
ocoanet pushed a commit to ocoanet/moq4 that referenced this pull request Jun 10, 2019
…erified mocks (devlooped#848)

* Test `VerifyNoOtherCalls` behavior re: data loops
* `VerifyNoOtherCalls` should verify each mock at most once
* Update the changelog
ishimko pushed a commit to ishimko/moq4 that referenced this pull request Sep 2, 2019
…erified mocks (devlooped#848)

* Test `VerifyNoOtherCalls` behavior re: data loops
* `VerifyNoOtherCalls` should verify each mock at most once
* Update the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifyNoOtherCalls causes stack overflow when mock setup returns the mocked object (since 4.11)
1 participant