Fix SetupAllProperties indexer regression & refactor accessor check methods for clarity
#902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Give them more precise names * Reduce code duplication * Reorder them into logical groups * Add missing methods for property check * Inline some single-use accessor check methods * Update call sites to use the new methods
stakx
commented
Aug 22, 2019
| .Append(expression.Method.Name, 4); | ||
| if (expression.Arguments.Count > paramFrom) | ||
| { | ||
| builder.AppendCommaSeparated("[", expression.Arguments.Skip(paramFrom), AppendExpression, "]"); |
There was a problem hiding this comment.
Not introduced by this refactoring, but weird nonetheless: Why do angle brackets appear in the formatting of a property getter expression?
stakx
changed the title
SetupAllProperties indexer regression & refactor accessor check methods for clarifySetupAllProperties indexer regression & refactor accessor check methods for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #901.