Simplify code in Match.Matches and It.IsAny<T>
#911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because `Match` matchers will already have checked `value is T` by the time the predicate delegate gets invoked.
by documenting that `IsAssignableFrom` generally yields the same results as the `is` operator when run on an `object`-typed variable. Note that this is removing the `IsComObject` check as well. This check was originally added because it was found that `IsAssignableFrom` does not always work properly for COM interfaces whereas the `is` works. Since we're generally going back on `is`, the COM check becomes redun- dant.
stakx
force-pushed
the
simplify-matchers
branch
from
394519b
to
950870c
Compare
ishimko
pushed a commit
to ishimko/moq4
that referenced
this pull request
Sep 2, 2019
In `Match.Matches`: * Split up `if` conditions so only null checks remain at top level * Turn second `if` into `else` * Instead of `return`ing early, set `canCastValueToT` bool to `false` * Rename variable `matchType` -> `t` for clarity * Remove redundant `is` check in `It` ... because `Match` matchers will already have checked `value is T` by the time the predicate delegate gets invoked. In `It.IsAny<T>`, `It.IsNotNull<T>`: * Simplify `It.IsAny<T>`, `It.IsNotNull<T>` matchers by documenting that `IsAssignableFrom` generally yields the same results as the `is` operator when run on an `object`-typed variable. Note that this is removing the `IsComObject` check as well. This check was originally added because it was found that `IsAssignable- From` does not always work properly when RCW `__ComObject` gets in- volved, whereas still `is` works even in that case. Since we're generally going back on `is`, the COM check becomes redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've long been bothered by the convoluted conditions inside
It.IsAny<T>andMatcher.Matches(which gets executed just before the former). These can be simplified & easier to understand.