Expose Mock.Setups, part 1: Basics
#984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice if `Mock.Setups` reported *all* setups instead of just a subset. Given that as a goal, we will eventually need a way to recognize such setups, so let's start by exposing these two flags.
This is because up until now, the 'overridden' flags have been purely an optimization to speed up future iterations over setups but correct- ness of operation was guaranteed even without it. Since updating these flags means some computational overhead, that update does not happen in a "hot" code path, and therefore does not happen at the earliest possible time. Now that `IsOverridden` is exposed, eventual consistency is no longer good enough, as this failing test demonstrates.
(A nice side effect of that is `Verify` and `VerifyAll` becoming more self-documenting.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a mock's
Setupscollection in the public API. Setups accessible via that (for now read-only) collection are of typeISetupand (for now) have three properties that describe some basic aspects of each setup:ExpressionIsConditionalIsOverriddenThis PR will be followed by a couple more that add more advanced functionality, e.g. to navigate the mock-setup or setup-setup object graph, and to perform custom verification.