Expose Mock.Setups, part 5: Simplify fluent setup & inner mock discovery
#995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not even using the `bool? ReturnsMock` method internally--instead we have a `bool ReturnsInnerMock` wrapper method. That might be a good sign that the 3VL is too clunky for practical use. Let's simplify even if the resulting method will be a little less precise.
stakx
force-pushed
the
mock-setups-5
branch
2 times, most recently
from
2c9097a
to
9cc6221
Compare
1. `ISetup` is mostly about introspection; methods with `out` params
aren't suited well to e.g. inspection in an IDE's Watch window.
2. What if we later want to add an `ISetup` sub-type representing all
setups created by `SetupAllProperties`? We'd have to add another
method with the same overall purpose. `OriginalSetup` OTOH is more
general and could more easily cover such a scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a follow-up to #989.)
This makes the following main changes:
bool? ISetup.ReturnsMock(out Mock innerMock)→
Mock ISetup.InnerMock { get; }bool ISetup.IsPartOfFluentSetup(out IFluentSetup fluentSetup)→
ISetup ISetup.OriginalSetup { get; }bool IInvocation.WasMatched(out ISetup matchingSetup)→
ISetup IInvocation.MatchingSetup { get; }(While methods with
outparameters are used extensively in Moq's code base, they are probably less suited for a good public API, not least because such members don't play nice with e.g. Visual Studio's Watch window—for users wanting to quickly inspect a mock's setups.)