Skip to content

Commit

Permalink
Move format to last since it takes time
Browse files Browse the repository at this point in the history
We want to fail ultimately, but this makes it possible to have a format error and still ensure build/test/pack/push work, even test the produced package via the CI feed, and leave the format fixing for later, instead of it blocking any progress up front.
  • Loading branch information
kzu committed Aug 29, 2022
1 parent f7b36cc commit 52c8089
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ jobs:
submodules: recursive
fetch-depth: 0

- name: ✓ ensure format
run: dotnet format --verify-no-changes -v:diag --exclude ~/.nuget

- name: ⚙ msbuild
uses: microsoft/setup-msbuild@v1.1

Expand Down Expand Up @@ -71,6 +68,9 @@ jobs:
dotnet tool install -g --version 4.0.18 sleet
sleet push bin --config none -f --verbose -p "SLEET_FEED_CONTAINER=nuget" -p "SLEET_FEED_CONNECTIONSTRING=${{ secrets.SLEET_CONNECTION }}" -p "SLEET_FEED_TYPE=azure" || echo "No packages found"
- name: ✓ ensure format
run: dotnet format --verify-no-changes -v:diag --exclude ~/.nuget

# Only push CI package to nuget.org for releases
- name: 🚀 nuget
if: github.event_name == 'release'
Expand Down

0 comments on commit 52c8089

Please sign in to comment.