Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop TimeoutSeconds and instead use the built-in Timeout from base FactAttribute #59

Closed
kzu opened this issue Sep 7, 2022 · 0 comments

Comments

@kzu
Copy link
Collaborator

kzu commented Sep 7, 2022

It's confusing to have both.

kzu added a commit that referenced this issue Oct 27, 2022
…ctAttribute

Leave the (non-browsable) legacy property so that existing code continues to compile, but otherwise just expose the Timeout property as-is.

We redeclare it so it's more accurate to the context of xunit.vsix in terms of what's measured.

Fixes #59
kzu added a commit that referenced this issue Oct 27, 2022
…ctAttribute

Leave the (non-browsable) legacy property so that existing code continues to compile, but otherwise just expose the Timeout property as-is.

We redeclare it so it's more accurate to the context of xunit.vsix in terms of what's measured.

Fixes #59
kzu added a commit that referenced this issue Oct 27, 2022
…ctAttribute

Leave the (non-browsable) legacy property so that existing code continues to compile, but otherwise just expose the Timeout property as-is.

We redeclare it so it's more accurate to the context of xunit.vsix in terms of what's measured.

Fixes #59
@kzu kzu closed this as completed in 3f36105 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant