Fixing the ExUnit async run logic to work on Elixir 1.12 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muzak was not working on Elixir 1.12, I debuged it and it was basically not requiring any tests, so there was no fail at all. I couldn't find the exact reason for it, but I saw there was the introduction of the function `ExUnit.async_run`, so I changed the `Task.async` to call it and everything worked!
|
@devonestes can this be merged to Muzak Pro as well? I had the same issue and this fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Muzak was not working on Elixir 1.12, I debuged it and it was basically
not requiring any tests, so there was no fail at all.
I couldn't find the exact reason for it, but I saw there was the introduction
of the function
ExUnit.async_run, so I changed theTask.asynctocall it and everything worked!