Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#37: implemented tool commandlet for Vscode #84

Merged
merged 10 commits into from
Oct 13, 2023
Merged

#37: implemented tool commandlet for Vscode #84

merged 10 commits into from
Oct 13, 2023

Conversation

aBega2000
Copy link
Contributor

Addresses: #37

  • added class Vscode.java
  • added cmd-vscode in Ide.properties and in Ide_de.properties
  • imported Vscode class and called the add method for Vscode in class CommandletManagerImpl.java
  • Changed the isBinary method in ToolCommandlet.java class from private to protected in order to override this method in the Vscode.java class

@aBega2000 aBega2000 marked this pull request as ready for review October 12, 2023 18:38
@aBega2000 aBega2000 self-assigned this Oct 12, 2023
@aBega2000 aBega2000 added vscode Microsoft visual studio code enhancement New feature or request commandlet labels Oct 12, 2023
@aBega2000 aBega2000 added this to the release:2024.01.001 milestone Oct 12, 2023
hohwille
hohwille approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aBega2000 thanks for your PR. You did all functionally correct 👍
I left a comment for improvement that you should please consider.

However, your implementation is incomplete:
VSCode is an IDE so you need to extend IdeCommandlet and also need to implement logic to add plugins (extensions), etc.
See #10

cli/src/main/java/com/devonfw/tools/ide/tool/vscode/Vscode.java Outdated Show resolved Hide resolved
aBega2000
aBega2000 commented Oct 13, 2023
View reviewed changes
Copy link
Contributor Author

@aBega2000 aBega2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added the getBinaryName() method to reduce duplicated code
  • Override the getBinaryName() method in the Vscode.java class
  • Fixed some conflicts that happened

@hohwille hohwille merged commit 6302174 into devonfw:main Oct 13, 2023
2 checks passed
@hohwille hohwille linked an issue Oct 13, 2023 that may be closed by this pull request
Implement ToolCommandlet for Visual Studio Code #37
Open
@hohwille hohwille mentioned this pull request Oct 13, 2023
Open
hohwille pushed a commit to hohwille/IDEasy that referenced this pull request Oct 24, 2023
@aBega2000 @hohwille
devonfw#37: implemented tool commandlet for Vscode (devonfw#84)
7c604da
hohwille pushed a commit to hohwille/IDEasy that referenced this pull request Oct 24, 2023
@aBega2000 @hohwille
devonfw#37: implemented tool commandlet for Vscode (devonfw#84)
5f864b5
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@tobka777 tobka777 added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@aBega2000 aBega2000

Labels
commandlet enhancement New feature or request reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. vscode Microsoft visual studio code
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.03.001
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Visual Studio Code
3 participants
@aBega2000 @hohwille @tobka777