Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devon4j api pom should use spring dependencies #37

Closed
jdiazgon opened this issue Nov 8, 2018 · 3 comments
Closed

devon4j api pom should use spring dependencies #37

jdiazgon opened this issue Nov 8, 2018 · 3 comments
Labels
bug Something isn't working enhancement New feature or request template maven-archetype to create new application.
Milestone

Comments

@jdiazgon
Copy link
Member

jdiazgon commented Nov 8, 2018

As the new devon4j-api is used to contain api related files like interfaces, I was trying to generate with CobiGen those templates there, so that we are compliant with the new architecture.

One of the templates that I want to generate on the devon4j-api project is SearchCriteriaTo. This class extends from AbstractSearchCriteriaTo which imports org.springframework.data.domain.Pageable;.

The problem is that, by default, the pom of devon4j-api does not define the spring related dependencies like:

    <dependency>
      <groupId>com.devonfw.java.starters</groupId>
      <artifactId>devon4j-starter-spring-data-jpa</artifactId>
    </dependency>

Therefore we get compilation errors as Pageable is not found.

I would like to have that dependency on the pom by default.

@jdiazgon jdiazgon added the enhancement New feature or request label Nov 8, 2018
@hohwille
Copy link
Member

hohwille commented Nov 8, 2018

@jdiazgon thanks for this excellent finding.
As the api should be minimal from dependencies point of view do not put a dependency on the starter but use spring-data-commons instead. Thanks.

@hohwille hohwille added this to the release:3.0.0 milestone Nov 8, 2018
@hohwille hohwille added bug Something isn't working template maven-archetype to create new application. labels Nov 8, 2018
@hohwille
Copy link
Member

hohwille commented Nov 8, 2018

Please fix here:
https://github.com/devonfw/devon4j/blob/develop/templates/server/src/main/resources/archetype-resources/api/pom.xml#L15
If you could provide a PR would be awesome.

@hohwille
Copy link
Member

Merged PR #40, hence done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request template maven-archetype to create new application.
Projects
None yet
Development

No branches or pull requests

2 participants