-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UrlUpdater changes both error and success timestamp #1343
Comments
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 4, 2023
added a test for a proper status.json refresh added new UrlUpdaterMockSingle class adjusted javadocs in UrlUpdaterMock classes
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 4, 2023
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 5, 2023
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 14, 2023
added new isValidContentType method to AbstractUrlUpdater (workaround for pip returning text/plain) added PipUrlUpdaterTest and mock adjusted test in UrlUpdaterTest to simulate bug in UrlUpdater moved getStatusJson method to AbstractUrlUpdaterTest
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 14, 2023
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 18, 2023
moved log message
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 18, 2023
added comment
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 18, 2023
adjusted javadocs fixed package name
jan-vcapgemini
added a commit
to jan-vcapgemini/ide
that referenced
this issue
Sep 19, 2023
improved getStatusJson test method refactored PipUrlUpdaterTest
hohwille
pushed a commit
that referenced
this issue
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
The
UrlUpdater
(update-urls.yml
) should updatestatus.json
in the following ways:error
section (current error HTTP status code and timestamp of now) if the previous error timestamp is older than the success timestamp.Actual behavior
There is total non-sense happening. See e.g. this commit where both success and error timestamps have been set to the exact same instant of time. At one moment of time the state can either be error or success but not both. The fun fact and the actual reason seems to lay in the error status code that is set to 200:
Steps to reproduce (bug) / Use Case of feature request (enhancement)
status.json
:https://github.com/devonfw/ide-urls/blob/055a0285b38376ea49f612ac4e60eeb75c74e817/pip/pip/3.2/status.json#L10
Related/Dependent Issues
Comments/Hints:
Maybe we broke that code that determines if something is success or error from the response.
Affected version:
The text was updated successfully, but these errors were encountered: