-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename architectures browser to solution browser #83
Rename architectures browser to solution browser #83
Comments
@maybeec What should be renamed? Website title, website url, folder structure? The folder structure is related with the url, but maybe we can override this. |
let's go the easiest way. for me it's critical that the url is showing solutions instead of architectures as well as wherever it's used, it should be named solution browser instead of architecture browser as we are more and more talking about solutions and less about architectures here. |
Yes let's go with the clean solution renaming the repo as well. Solutions or solution browser is both fine. |
OK, I would vote for Solutions as a title |
I already change the title in Solutions: #95 Maybe it's not the best solution to rename the repository into solutions, because there is a subfolder |
The name of the repo is not the problem. It is a bit strange but not a real problem. The problem is that the needed changes in the website repo will lead to URLs ending with /solutions/solutions/. The first one is the folder where the solution browser is deployed and the other is the folder in the repo. This is a bit strange. In the meantime, I renamed the repo: https://github.com/devonfw/solutions |
@maybeec Maybe we can use something like "solution" (without the s) or "result" (because it is a result of the solution browser) or "content" (because it is the content of the solution browser) for the folder in the repo. But in these cases, I would suggest renaming the folder at deployment time because all three would be strange names for the folder in the repo and would only make sense in the context of the URL. |
@tobka777 As I renamed the repo please take care of the submodule in the website repo when you do the necessary changes there. Currently, it is working because of github magic but it would be cleaner to change the URL and name of the submodule. |
Fine for me, but honestly, keep in mind KISS. I feel we should simply rename the folder to solution only. Nobody cares about the name but more will care on maintenance to get an understanding of the magic and renaming |
Please rename the architectures browser to solution browser as we will show different solutions there and not only architectures.
The text was updated successfully, but these errors were encountered: