Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename architectures browser to solution browser #83

Closed
maybeec opened this issue Nov 25, 2021 · 10 comments · Fixed by devonfw/devonfw.github.io#278 or #98
Closed

Rename architectures browser to solution browser #83

maybeec opened this issue Nov 25, 2021 · 10 comments · Fixed by devonfw/devonfw.github.io#278 or #98
Assignees
Labels

Comments

@maybeec
Copy link
Member

maybeec commented Nov 25, 2021

Please rename the architectures browser to solution browser as we will show different solutions there and not only architectures.

@maybeec maybeec added enhancement New feature or request Campus_21_4_website labels Nov 25, 2021
@tobka777
Copy link
Member

tobka777 commented Dec 3, 2021

@maybeec What should be renamed? Website title, website url, folder structure? The folder structure is related with the url, but maybe we can override this.

@tobka777 tobka777 self-assigned this Dec 3, 2021
@maybeec
Copy link
Member Author

maybeec commented Dec 3, 2021

let's go the easiest way. for me it's critical that the url is showing solutions instead of architectures as well as wherever it's used, it should be named solution browser instead of architecture browser as we are more and more talking about solutions and less about architectures here.

@SchettlerKoehler
Copy link
Member

The title of the page should be changed to Solutions. @maybeec or do you prefer Solution Browser?
In the URL architectures should be changed to solutions.
@maybeec Should we also rename the repo?

@maybeec
Copy link
Member Author

maybeec commented Dec 8, 2021

Yes let's go with the clean solution renaming the repo as well. Solutions or solution browser is both fine.

@SchettlerKoehler
Copy link
Member

OK, I would vote for Solutions as a title

@tobka777
Copy link
Member

tobka777 commented Dec 10, 2021

I already change the title in Solutions: #95

Maybe it's not the best solution to rename the repository into solutions, because there is a subfolder solutions in the repository as well.

@SchettlerKoehler
Copy link
Member

The name of the repo is not the problem. It is a bit strange but not a real problem. The problem is that the needed changes in the website repo will lead to URLs ending with /solutions/solutions/. The first one is the folder where the solution browser is deployed and the other is the folder in the repo. This is a bit strange.
@maybeec and I discussed that but we have not found a better name for the folder or the deployment folder. If you have one please suggest it.

In the meantime, I renamed the repo: https://github.com/devonfw/solutions

@SchettlerKoehler
Copy link
Member

@maybeec Maybe we can use something like "solution" (without the s) or "result" (because it is a result of the solution browser) or "content" (because it is the content of the solution browser) for the folder in the repo. But in these cases, I would suggest renaming the folder at deployment time because all three would be strange names for the folder in the repo and would only make sense in the context of the URL.

@SchettlerKoehler
Copy link
Member

@tobka777 As I renamed the repo please take care of the submodule in the website repo when you do the necessary changes there. Currently, it is working because of github magic but it would be cleaner to change the URL and name of the submodule.

@maybeec
Copy link
Member Author

maybeec commented Dec 11, 2021

@maybeec Maybe we can use something like "solution" (without the s) or "result" (because it is a result of the solution browser) or "content" (because it is the content of the solution browser) for the folder in the repo. But in these cases, I would suggest renaming the folder at deployment time because all three would be strange names for the folder in the repo and would only make sense in the context of the URL.

Fine for me, but honestly, keep in mind KISS. I feel we should simply rename the folder to solution only. Nobody cares about the name but more will care on maintenance to get an understanding of the magic and renaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment