Fixing ECS: Moving to listClusters, ignoring headers (there are none … #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the list response)
kesor
reviewed
Feb 6, 2018
index.html
Outdated
| @@ -998,21 +998,37 @@ | |||
| function createTableHead(headings) { | |||
| const tr = $('<tr></tr>') | |||
| tr.append($('<th class="text-center">#</th>')) | |||
| for (let h=0; h<headings.length; h++) { | |||
| tr.append($(`<th>${headings[h]}</th>`)) | |||
| if (headings.length == 0) { | |||
There was a problem hiding this comment.
The headings for listClusters does have one element, "List".
Also check CodeDeploy.listOnPremisesInstances line 443 to see how this can be done without special exceptions in code.
|
Can also choose any title via JMESPath.
…On Tue, 6 Feb 2018 at 19:27 Omer Hamerman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In index.html
<#11 (comment)>
:
> @@ -998,21 +998,37 @@
function createTableHead(headings) {
const tr = $('<tr></tr>')
tr.append($('<th class="text-center">#</th>'))
- for (let h=0; h<headings.length; h++) {
- tr.append($(`<th>${headings[h]}</th>`))
+ if (headings.length == 0) {
Basically, I can check if the head is empty, just wanted to put some
meaningful title.
I'll change it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAbkNoXh0nkppbUPV1OEDd19W16tfkxks5tSItogaJpZM4R65R4>
.
|
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in the list response)