Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAN-2018] new sponsors added to van2018 and updating treasuredata sponsor image #3838

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

rmkbow
Copy link
Contributor

@rmkbow rmkbow commented Jan 17, 2018

adding realtor.com sponsor
updating treasuredata logo image (less wasted horizontal whitespace)
adding sponsors to vancouver 2018

…sted whitespace). adding sponsors to vancouver 2018
@kmugrage
Copy link
Contributor

@rmkbow - we avoid changing logos for events which have happened in the past, which this PR would do.

Please see #503 and https://github.com/devopsdays/devopsdays-web/blob/master/utilities/README.md for context.

@rmkbow
Copy link
Contributor Author

rmkbow commented Jan 18, 2018

@kmugrage doesn't that only apply to rebranding? this one is like fixing an image that has been needsmorejpg?

if it applies should I rename the old one and keep the new one with the base name, and update old references to use the updated old sponsor name?

or would best course of action to just create copies sponsor data/images of existing sponsors and not reuse existing sponsor data/images them at all then so there isn't this historical dependency? like each event keeps it's own 2018-Vancouver-sponsorname data/image

@bridgetkromhout
Copy link
Collaborator

Ah yes, this update of the image doesn’t change it visually. So it’s fine in this case. We want to keep a sponsor not event or year specific - there is often re-use.

@bridgetkromhout bridgetkromhout merged commit 1283315 into devopsdays:master Jan 18, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants