-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Empirical contribution infrastructure #356
Conversation
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 79.02% 79.04% +0.01%
==========================================
Files 306 306
Lines 34972 34971 -1
==========================================
+ Hits 27637 27643 +6
+ Misses 7335 7328 -7
|
I agree with the now-deleted paragraph about getting human eyes on the code and not relying completely on automation, but given limited reviewer time I'm not sold on the value of manually running automated tests that are already being run. The previous guidelines also didn't match our current practice.
updates discussed 2020-09-15 lab meeting
Double check that license includes all 3rd party software licenses. |
Double check that we include everyone that has contributed to Empirical |
@mmore500 and/or @amlalejini if one of you has a chance to look at it, this is another PR that should probably get merged before JOSS submission so that the reviewers (and users!) can easily find license and contributing information This technically depends on #483, which is a super tiny fix that just needs someone to peek at it before it gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Positive changes. Not sure why this was sitting around in limbo for 3 years. ¯_(ツ)_/¯
Looks great. Can we just merge this instead of #483 and close that PR? |
Yeah, good call! Thanks for reviewing! |
Wow, looks like GitHub auto-detects situations like this and automatically counted that PR as merged when I merged this one! Cool! |
This pull request: