Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Empirical contribution infrastructure #356

Merged
merged 14 commits into from
Jun 11, 2023

Conversation

emilydolson
Copy link
Collaborator

This pull request:

  • Moves LICENSE.md to root, which is where people usually look for it.
  • Adds a CONTRIBUTING.md file with instructions for how to contribute

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #356 (5b9d3ef) into master (2aa1833) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   79.02%   79.04%   +0.01%     
==========================================
  Files         306      306              
  Lines       34972    34971       -1     
==========================================
+ Hits        27637    27643       +6     
+ Misses       7335     7328       -7     
Impacted Files Coverage Δ
include/emp/bits/BitVector.hpp 72.41% <0.00%> (ø)
include/emp/math/Random.hpp 69.19% <100.00%> (+0.56%) ⬆️

... and 3 files with indirect coverage changes

emilydolson and others added 4 commits August 19, 2020 01:52
I agree with the now-deleted paragraph about getting human eyes on the code and not relying completely on automation, but given limited reviewer time I'm not sold on the value of manually running automated tests that are already being run. The previous guidelines also didn't match our current practice.
updates discussed 2020-09-15 lab meeting
@amlalejini
Copy link
Member

Double check that license includes all 3rd party software licenses.

@amlalejini
Copy link
Member

Double check that we include everyone that has contributed to Empirical

@emilydolson
Copy link
Collaborator Author

@mmore500 and/or @amlalejini if one of you has a chance to look at it, this is another PR that should probably get merged before JOSS submission so that the reviewers (and users!) can easily find license and contributing information

This technically depends on #483, which is a super tiny fix that just needs someone to peek at it before it gets merged

Copy link
Member

@mmore500 mmore500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positive changes. Not sure why this was sitting around in limbo for 3 years. ¯_(ツ)_/¯

@mmore500
Copy link
Member

Looks great. Can we just merge this instead of #483 and close that PR?

@emilydolson
Copy link
Collaborator Author

Yeah, good call! Thanks for reviewing!

@emilydolson emilydolson merged commit 79c4ffc into master Jun 11, 2023
@emilydolson
Copy link
Collaborator Author

Wow, looks like GitHub auto-detects situations like this and automatically counted that PR as merged when I merged this one! Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants