Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coding style #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomers
Copy link
Collaborator

@tomers tomers commented Jul 19, 2019

Priority

Low

What Changed & Why

Improve coding style in selected places. No functional change.

Testing

I ran unit-tests, by I am not comfortable enough with it. This PR needs to be tested in the fields first...

@tomers tomers requested a review from Auspicus July 19, 2019 20:11
promise = promise.then(middleware.error)
})
applyMiddleware (method, promise) {
console.assert(['req', 'res', 'error'].includes(method))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like debug-code 😉

@auvipy
Copy link
Collaborator

auvipy commented Jun 5, 2020

conflicts needed to be fixed

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants