Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #250 Added a means to disable errors for missing resource definitions. #251

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

ibustosatlegalzoom
Copy link
Contributor

Screenshot

N/A

What Changed & Why

Introduced a flag disableErrorsForMissingResourceDefinitions to effectively disable the error 'API resource definition for model "XWY" not found'. Instead of throwing the error though, we are invoking the Logger's error method to let users know they should fix it.

Since invokers of the modelFor method expect a model, we are returning an empty model structure which has proved effective in our tests.

Testing

Just run the tests.

Documentation

Updated the README file with instructions.

@auvipy auvipy self-requested a review July 2, 2023 07:21
@auvipy auvipy merged commit 4e5ef27 into devour-js:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants