Add support for "prepare" script in descriptor #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prepare script consists of commands that are run as root on the target after installing the necessary packages, but before running the build script. This is necessary to fix up an ARM build system issue on Ubuntu Trusty (see bitcoin/bitcoin#8212).
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Jun 17, 2016
|
I see an However I slightly prefer this solution as it enforces privilege separation, by not allowing everything in the entire build script to use |
|
ACK 46c6539 |
|
OK. I'll merge this, but I'm away from my key so it will have to wait until next week. |
|
@devrandom Thanks for your reply. |
|
Thank you for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prepare script consists of commands that are run as root on the target after installing the necessary packages, but before running the build script.
This is necessary to fix up an ARM build system issue on Ubuntu Trusty (see bitcoin/bitcoin#8212).