Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should redirect to previous page after logging in #172

Merged
merged 10 commits into from
Feb 11, 2022

Conversation

xinglee23
Copy link
Collaborator

@xinglee23 xinglee23 commented Feb 7, 2022

Description

fix bug: should redirect to previous page after logging in

Related Issue

Close #149

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

  • Unit tests and integration tests passed
  • No reduction in test coverage
  • Documentation is up to date (if appropriate)
  • Related issues linked using fixes #number

@vercel
Copy link

vercel bot commented Feb 7, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @devrsi0n on Vercel.

@devrsi0n first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/devrsi0n/chirpy/As16gpPY17pspfE1v9JLrVUsEhVG
✅ Preview: https://chirpy-git-fork-xinglee23-bugfix-149-devrsi0n.vercel.app

@devrsi0n devrsi0n changed the title Bugfix 149 fix: should redirect to previous page after logging in Feb 7, 2022
src/lib/constants.ts Outdated Show resolved Hide resolved
src/pages/auth/redirecting.tsx Outdated Show resolved Hide resolved
@devrsi0n devrsi0n merged commit cb0a8f3 into devrsi0n:main Feb 11, 2022
devrsi0n added a commit that referenced this pull request Feb 26, 2022
* fix(deps): update dependency framer-motion to v6.2.4 (#165)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* feat: web notification (#147)

* feat: web notification

* feat: send message with a test request

* feat: set up mutation event

* feat: send notification to site owner

* fix: window is undefined

* feat: add title and icon to notification

* feat: focus on existing tab or open a new tab after click a notification

* feat: add body to notification

* fix: refactor the sw

* feat: only register notification when user is posting

* feat: add a popover to ask user notification permission

* fix: delete notification subscription

* feat: add a toast to notify user a new service worker is available

* feat: add notification of reply

* feat: save like notificatioin

* fix: delete like notification failed

* feat: add comment deleted notificatioin

* fix: prettier is not working

* feat: delete the existing comment after deleted a comment

* fix: build error

* fix: ut error

* fix: cypress error

* docs: update progress

* fix: should redirect to previous page after logging in (#172)

* fix: fix bug Footer should be sticky to the bottom

* fix: fix bug Footer should be sticky to the bottom

* fix: fix bug should redirect to previous page after logging in

* fix: change sessionStorage name

* fix: change

* fix: change sessionStorage and localSession key

* fix: sessionStorage bugfix

Co-authored-by: 吴兴利 <xinglee@Xinglees-MacBook-Pro.local>

* refactor: use next-auth callback url  (#174)

* fix: use next-auth callback url

* fix: remove stale comment

* fix: update comment

* fix: remove a duplicated environment variable

* fix: remove comment script url on blog page

* fix: add notification type seed

* feat: add environment badges (#179)

* chore(deps): update dependency superjson to 1.8.1 [security] (#178)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(deps): update dependency type-fest to v2.11.2 (#166)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Polish web notification (#181)

* fix: polish favicon

* fix: don't show popup if user deny the notification permission

* feat: add a playground page for testing

* fix: remove unused variables

* fix(deps): update tiptap packages (#167)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Qing <7880675+devrsi0n@users.noreply.github.com>

* fix: polish favicon (#183)

* fix(deps): update dependency urql to v2.1.3 (#171)

* Fix: database schema migration (#186)

* fix: migrate database

* fix: squash notification database schema

* fix: remove alter

* feat: add hasura ci/cd github action

* Feat: use on-demand ISR and use middleware to protect API and pages (#188)

* fix: prepare for next-auth middleware

* fix: use middleware to check the authorized

* fix: use next-auth middleware to protect pages

* feat: use ondemand revalidate when hasura events happening

* fix: enable swc minify

* fix: squash schema

* fix: cypress test

* fix: missing env

* chore: polish readme image

* fix: cypress index page

* fix: cypress test failed

* fix: cypress test failed (#192)

* fix: hasura ci target branch

* fix: cypress error

* fix: test error (#195)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Xinglee23 <xinglee23@outlook.com>
Co-authored-by: 吴兴利 <xinglee@Xinglees-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should redirect to previous page after logging in
2 participants