Latest github files Login Failed: Invalid login! Please try again.

[rststeam]

After pulling latest files from github i get following error Login Failed: Invalid login! Please try again ; When i try to log in into gamepanel as client or admin Tryed on Admin and Demo account. Passwords are good. Are there any changes in database?

http://puu.sh/6dS4Q.png

[rststeam]

Re: Also did a quick test restored back githhub files from 6.01.2014 that i have on PC and login works then. So i guess it's code issue.

[antoniobenedetti]

I can't reproduce this.

[antoniobenedetti]

Did you do clean install of the database too?

[devryan]

The login now is a little different in the sense that it does the login
process in the correct order now.

This may screw up a number of current installs though
On Jan 8, 2014 7:54 AM, "rststeam" notifications@github.com wrote:

After pulling latest files from github i get following error Login Failed:
Invalid login! Please try again. Tryed on Admin and Demo account. Passwords
are good. Are there any changes in database?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67
.

[rststeam]

@antoniobenedetti No i didn't do clean install. I have servers setup on it i can't do clean install each time

[devryan]

Rule #1 of a production system: Don't do your testing on it

You should have a separate gpx install for testing the github changes, or at least backups. There are a lot of changes going in recently, the goal being for these to go into the next official release, Master 3.0.12, so there will be a lot of changes.

[rststeam]

I have backups always of my stuff. I like to test on running systems since then all bugs and errors are noticable right away.

[devryan]

Anywho, did the password on the account(s) that didnt work have any apostrophe ' characters or any non-alphanumeric? This may have been why after this update, things broke. Has to do with the base64 encoding.

[rststeam]

One password was demouser so i would say no. Must be something about database query. Or to make sql install file like 3.11.1

[devryan]

Hmm. That's weird. I wonder if this change broke things for anyone else.
On Jan 12, 2014 10:09 AM, "rststeam" notifications@github.com wrote:

One password was demouser so i would say no. Must be something about
database query. Or to make sql install file like 3.11.1

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-32128854
.

[rststeam]

Holdon just making new test installation seperated from my old one. Gonna post details in few minuts

[rststeam]

It's working on clean install. So must be some updated file is messing up

[devryan]

How have you been updating your code? Git pull, or manually copying new
files in?
On Jan 12, 2014 10:56 AM, "rststeam" notifications@github.com wrote:

It's working on clean install. So must be some updated file is messing up

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-32130264
.

[rststeam]

Manually inserted new files over old. Also tryed to delete old and the upload new then all errors pop out. I belive this is only database issue bettewen old and new Sql install file. Since new installation works fine but new over old fails.

[devryan]

Old and new SQL install file? How "old" was the old one? There shouldn't be any changes other than a couple game default tweaks...

[RogEnk]

I can report same issue having applied the Injection patch, this has broken logins.
http://gamepanelx.com/forums/viewtopic.php?f=11&t=4321

Rolled back login_actions.php and logins work again.

[devryan]

Was your old username and password containing any special characters, or spaces?

I've confirmed that the current codebase is not adding any weird characters etc to the login; I see my normal user+pass.

Also, how are you guys uploading the github fixes? Note that for the new fixes, there are multiple files involved, namely ajax/ajax.php and ajax/login_actions.php, and ajax/network_actions.php.

[RogEnk]

No special characters or spaces, Upper, lower case letters and digits only.

[rststeam]

How we upload?

Well i download all files in zip then reupload via ftp. It was always working until now. This is odd error since OLD installation with latest files = fail , and clean new install works

[RogEnk]

I replaced contents of old file with the new contents from here.

Permissions remained the same.

[devryan]

I wonder if that ZIP that GitHub provides is always up-to-date, or if it's generated every so often. No idea.

Maybe try a git pull. I feel like maybe your ajax/ajax.php file was not updated, only your ajax/login_actions.php, so that's causing an issue.

Can you guys do a stat on these files?

cd <gpx web root>
stat ajax/ajax.php
stat ajax/login_actions.php
stat ajax/network_actions.php

[RogEnk]

As requested, this is post reversion.

stat ajax/ajax.php
File: ajax/ajax.php' Size: 4297 Blocks: 16 IO Block: 4096 regular file Device: 801h/2049d Inode: 45336394 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 501/overlord) Gid: ( 501/overlord) Access: 2014-01-14 18:46:52.000000000 +0000 Modify: 2013-10-16 20:07:09.000000000 +0000 Change: 2013-10-30 16:26:10.000000000 +0000 [root@overlord panel]# stat ajax/login_actions.php File:ajax/login_actions.php'
Size: 5486 Blocks: 16 IO Block: 4096 regular file
Device: 801h/2049d Inode: 45336641 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 501/overlord) Gid: ( 501/overlord)
Access: 2014-01-15 14:57:36.000000000 +0000
Modify: 2013-09-09 17:24:28.000000000 +0000
Change: 2014-01-14 10:24:04.000000000 +0000
[root@overlord panel]# stat ajax/network_actions.php
File: `ajax/network_actions.php'
Size: 3692 Blocks: 8 IO Block: 4096 regular file
Device: 801h/2049d Inode: 45336408 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 501/overlord) Gid: ( 501/overlord)
Access: 2013-10-30 16:37:08.000000000 +0000
Modify: 2013-10-16 20:07:09.000000000 +0000
Change: 2013-10-30 16:26:10.000000000 +0000

[devryan]

Post...reversion? Implying that you reverted to the broken or the old working files?

[RogEnk]

Old working files Ryan. I applied the hotfix for the SQL Injection, that appeared to break the logins. I changed (as recommended) only the login_actions.php file. The stat output above is the results after rolling back to the original login_actions.php.

Hope this helps!